Apply metadata filters case insensitively #595
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
In most of our notifiers, string filters are applied case insensitively as usually you'd always want to filter both 'password' and 'Password' — the casing doesn't matter
In the PHP library, filters have always been case sensitive, which caused issues when filtering cookies by default — the
getallheaders
PHP function (and our own fallback) use an uppercase first letter for header names (Cookie
), but Laravel uses lowercase headers (cookie
)We could decide that headers should always be lowercased (or uppercased, or aLtErNaTe case) but this seems like a good excuse to bring PHP more inline with our other libraries
NB: PHP applies filters if a string contains the filter, rather than exactly matching. I think changing that would be considered a breaking change as it could result in us recording data that should have been filtered, whereas this change could only filter more data than before
Changeset
stripos
rather thanstrpos
when checking if filters match