Fix invalid curl_setopt (v2) #614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is now a fatal error in PHP 8
These are no longer installable on the default
Newer composer versions hang forever when installing. We also can't rollback to a specific version because trying to do so throws an error (CURLOPT_PROTOCOLS isn't defined in HHVM 3.6)
kattrali
approved these changes
Nov 4, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
In PHP 8,
curl_setoptwill now throw if an undefined option is used. We were usingCURL_IPRESOLVE_V4as an option, when it's actually a value, so all error reports failed before being sentAFAICT this has always been an error, but earlier PHP version silently ignored it — see the docs from 2013
We need to make significant changes to the test suite to run the tests on newer PHP versions. We haven't don that now as this change is so small and isn't tested in the test suite anyway
Changeset
curl_setopusageTesting
This was tested manually as the test suite doesn't cover it — the changed function is always mocked