Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.x: Add missing timeout property #664

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Conversation

imjoehaines
Copy link
Contributor

Goal

Add missing timeout property as PHP 8.2 deprecated adding dynamic properties to classes

The timeout property didn't need to be dynamic, it just wasn't added as a real property

@imjoehaines imjoehaines requested a review from tomlongridge July 11, 2023 10:54
PHP 8.2 deprecated adding dynamic properties to classes

The timeout property didn't need to be dynamic, it just wasn't added as
a real property
@imjoehaines imjoehaines force-pushed the 2.x/add-timeout-property branch from 6868c79 to d2ec689 Compare July 11, 2023 10:56
@imjoehaines imjoehaines merged commit 1a1fd8e into 2.10 Jul 11, 2023
@imjoehaines imjoehaines deleted the 2.x/add-timeout-property branch July 11, 2023 11:32
@imjoehaines imjoehaines mentioned this pull request Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants