Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugsnag breaks with Sidekiq 5.0.0 #357

Closed
reubenbrown opened this issue Apr 25, 2017 · 0 comments
Closed

Bugsnag breaks with Sidekiq 5.0.0 #357

reubenbrown opened this issue Apr 25, 2017 · 0 comments

Comments

@reubenbrown
Copy link
Contributor

reubenbrown commented Apr 25, 2017

After updating sidekiq to version 5.0.0 the sidekiq process will not start due to an uninitialized constant in bugsnag.

Below is the backtrace:

There was an error while trying to load the gem 'bugsnag'.
Gem Load Error is: uninitialized constant Sidekiq::Middleware::Server
Backtrace for gem load error is:
/.rvm/gems/ruby-2.4.0/gems/bugsnag-5.3.1/lib/bugsnag/sidekiq.rb:30:in `block (2 levels) in <top (required)>'
/.rvm/gems/ruby-2.4.0/gems/sidekiq-5.0.0/lib/sidekiq.rb:143:in `server_middleware'
/.rvm/gems/ruby-2.4.0/gems/bugsnag-5.3.1/lib/bugsnag/sidekiq.rb:29:in `block in <top (required)>'
/.rvm/gems/ruby-2.4.0/gems/sidekiq-5.0.0/lib/sidekiq.rb:73:in `configure_server'
/.rvm/gems/ruby-2.4.0/gems/bugsnag-5.3.1/lib/bugsnag/sidekiq.rb:28:in `<top (required)>'
/.rvm/gems/ruby-2.4.0/gems/bugsnag-5.3.1/lib/bugsnag.rb:127:in `block in <top (required)>'
/.rvm/gems/ruby-2.4.0/gems/bugsnag-5.3.1/lib/bugsnag.rb:125:in `each'
/.rvm/gems/ruby-2.4.0/gems/bugsnag-5.3.1/lib/bugsnag.rb:125:in `<top (required)>'
/.rvm/gems/ruby-2.4.0/gems/bundler-1.14.6/lib/bundler/runtime.rb:91:in `require'
/.rvm/gems/ruby-2.4.0/gems/bundler-1.14.6/lib/bundler/runtime.rb:91:in `block (2 levels) in require'
/.rvm/gems/ruby-2.4.0/gems/bundler-1.14.6/lib/bundler/runtime.rb:86:in `each'
/.rvm/gems/ruby-2.4.0/gems/bundler-1.14.6/lib/bundler/runtime.rb:86:in `block in require'
/.rvm/gems/ruby-2.4.0/gems/bundler-1.14.6/lib/bundler/runtime.rb:75:in `each'
/.rvm/gems/ruby-2.4.0/gems/bundler-1.14.6/lib/bundler/runtime.rb:75:in `require'
/.rvm/gems/ruby-2.4.0/gems/bundler-1.14.6/lib/bundler.rb:107:in `require'
/sample_app/config/application.rb:9:in `<top (required)>'
/sample_app/config/environment.rb:2:in `require'
/sample_app/config/environment.rb:2:in `<top (required)>'
/.rvm/gems/ruby-2.4.0/gems/sidekiq-5.0.0/lib/sidekiq/cli.rb:255:in `require'
/.rvm/gems/ruby-2.4.0/gems/sidekiq-5.0.0/lib/sidekiq/cli.rb:255:in `boot_system'
/.rvm/gems/ruby-2.4.0/gems/sidekiq-5.0.0/lib/sidekiq/cli.rb:54:in `run'
/.rvm/gems/ruby-2.4.0/gems/sidekiq-5.0.0/bin/sidekiq:12:in `<top (required)>'
/.rvm/gems/ruby-2.4.0/bin/sidekiq:22:in `load'
/.rvm/gems/ruby-2.4.0/bin/sidekiq:22:in `<main>'
/.rvm/gems/ruby-2.4.0/bin/ruby_executable_hooks:15:in `eval'
/.rvm/gems/ruby-2.4.0/bin/ruby_executable_hooks:15:in `<main>'

It appears the issue is happening here because sidekiq removed server middleware
so the Sidekiq::Middleware::Server::Logging constant no longer exists (See here for more info).

Simply reverting this commit fixes the issue. I can open a pull request reflecting this change.

reubenbrown added a commit to reubenbrown/bugsnag-ruby that referenced this issue Apr 25, 2017
kattrali pushed a commit that referenced this issue Oct 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant