Ensure Sidekiq app_type is not overwritten when rails is a dependency #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes rails is ran as a dependency of another integration (eg. Sidekiq). But since the rails initializer runs after the integration, the app_type that is normally set ends up overwritten. Each integration has it's own logic that determines if rails is a dependency or the main actor. This flag can now be set by them to make sure the app_type won't change.
When the Sidekiq::CLI is defined, it means the "bin/sidekiq" was the entrypoint, so the app_type should be defined as sidekiq and not rails even if rails is loaded as a dependency Closes bugsnag#285
Draiken
force-pushed
the
sidekiq_app_type_overwritten
branch
from
61b3657
to
72389be
Compare
|
Thank you for the patch, @Draiken! This is probably a solution which could be applied to Mailman and Resque, though I can take a look at verifying those as well. Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #285. It's possible this same bug happens with other integrations, but I only use Sidekiq and didn't verify that.