Preserve field types when truncating large payloads #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kattrali
force-pushed
the
fix-invalid-truncated-payloads
branch
4 times, most recently
from
a9bbd18
to
9b12496
Compare
* Handle array type cases * Handle trimming and truncation * Handle recursive Enumerables * Add tests \o/
kattrali
force-pushed
the
fix-invalid-truncated-payloads
branch
from
9b12496
to
728bb36
Compare
|
Added tests and handling for a few edge cases, such as floating-point values and arrays which contains objects other than hashes. Thanks, @duncanhewett! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When truncating large payloads the event hash is passed into the
reduce_hash_size' helper. This currently converts booleans and integers to strings which can result the payload being rejected by Bugsnag (particularly theinProject` field in a stackframe).This will preserve integers and booleans in the truncated payload.