Add support for 'block syntax' on Bugsnag.notify calls #292
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users to customize the error report sent to Bugsnag using ruby block syntax on each
Bugsnag.notify
call as follows:As well as being an arguably cleaner syntax than before, this also exposes the full power of accessing the
Notification
object to everyBugsnag.notify
call - provideing a single interface to error report customization. This meansBugsnag.notify
report customization andbefore_notify_callbacks
can all share a single documentation.This PR is the super un-opinionated version, which does not break existing APIs.
I actually propose we remove all the slightly hacky
overrides
logic and replace with this, which would be an api-incompatible change requiring a major version bump - any thoughts?