Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't log API key #299

Merged
merged 1 commit into from
Jun 23, 2016

Commits on Jun 22, 2016

  1. Don't log API key

    [This
    PR](bugsnag@5eaddd8)
    was a good start but there was more.
    
    Used to find where more changes were needed
    ```bash
    ~/src/bugsnag-ruby (master)$ grep -r "#{api_key}" .
    ./lib/bugsnag/notification.rb:        Bugsnag.warn "Your API key (#{api_key}) is not valid, couldn't notify"
    ./lib/bugsnag/notification.rb:        Bugsnag.log("Notifying #{endpoint} of #{@exceptions.last.class} from api_key #{api_key}")
    ```
    
    Should not log API key since logs are not necessarily kept as secret a
    environment variables. The log steam should be keeping track of which
    service/box is doing the logging in order to identify which client of
    the API is having issues. We have kept the logging of the variable for
    an invalid API key.
    Julian Borrey committed Jun 22, 2016
    Configuration menu
    Copy the full SHA
    8c96928 View commit details
    Browse the repository at this point in the history