Correctly hook on Action Controller

[rafaelfranca]

When an initializer load the ActionController::Base constant all the on_load triggers for :action_controller are executed. This cause a lot of load order issues.

Gems should always use ActiveSupport.on_load to extent behavior of the Rails frameworks.

Also using ActiveSupport.on_load(:action_controller) we can make sure that both ActionController::Base and ActionController::Api are extended.

This is related with #337 and #314.

[emaiax]

I hope this can be merged soon.

[cupakromer]

ping 💙

Hoping this gets merged soon. Just ran into a strange issue with Rails 5 ActionController::API and render :action (I am using Jbuilder for the renderer). All requests return the string body of " ". Applying this patch resolves the issue (as does removal of the bugsnag gem).

This can easily be reproduced with a new Rails 5.0.1 app, Jbuilder 2.6.1, and bugsnag 5.0.1. Here is the complete controller and view I used:

# app/controllers/widgets_controller.rb
class WidgetsController < ActionController::API
  def index
    render :index
  end
end

# app/views/widgets/index.json.jbuilder
json.data "API Testing"

[kattrali]

Thank you! This will be in a release shortly.