Session tracking fixes #412
Conversation
bugsnag.gemspec
Outdated
| @@ -18,4 +18,5 @@ Gem::Specification.new do |s| | |||
| ] | |||
| s.require_paths = ["lib"] | |||
| s.required_ruby_version = '>= 1.9.2' | |||
| s.add_runtime_dependency 'concurrent-ruby', '~> 1.0.5' | |||
There was a problem hiding this comment.
Should probably be ~> 1.0
spec/session_tracker_spec.rb
Outdated
| @@ -3,13 +3,17 @@ | |||
| require 'spec_helper' | |||
| require 'json' | |||
|
|
|||
| module Bugsnag | |||
| class SessionTracker | |||
| attr_accessor :track_sessions | |||
There was a problem hiding this comment.
It was being used to access a variable to stop the delivery threads being spun up, but is obsolete now.
spec/session_tracker_spec.rb
Outdated
| Bugsnag.session_tracker.create_session | ||
| Bugsnag.session_tracker.start_session | ||
| while Bugsnag.session_tracker.session_counts.size == 0 | ||
| sleep(0.05) |
spec/session_tracker_spec.rb
Outdated
| conf.release_stage = "test_stage" | ||
| end | ||
| Bugsnag.session_tracker.create_session | ||
| Bugsnag.session_tracker.start_session |
There was a problem hiding this comment.
Can we just call Bugsnag.start_session
lib/bugsnag/session_tracker.rb
Outdated
| sessions = [] | ||
| @session_counts.each do |min, count| | ||
| counts = @session_counts.dup |
There was a problem hiding this comment.
You actually want
counts = @session_counts
@session_counts = Concurrent::Hash.new(0)
counts.each ...With the current implementation there is still a race condition.
lib/bugsnag/session_tracker.rb
Outdated
| end | ||
|
|
||
| def deliver(session_counts) | ||
| if session_counts.length == 0 |
There was a problem hiding this comment.
be consistent about using @session_counts or session_counts in this file. I would use the member variable.
CHANGELOG.md
Outdated
| @@ -6,7 +6,7 @@ Changelog | |||
| ### Enhancements | |||
|
|
|||
| * Adds support for tracking sessions and crash rate by setting the configuration option `configuration.track_sessions` to `true`. | |||
| Sessions can be manually created using `Bugsnag.start_session`, and manually delivered using `Bugsnag.send_sessions`. | |||
| Sessions can be manually created using `Bugsnag.create_session`, and manually delivered using `Bugsnag.send_sessions`. | |||
There was a problem hiding this comment.
Don't mention the send_sessions thing. Ideally that shouldn't even be public imo. It doesn't look like it's defined on Bugsnag anyway. The function should be start_session not create_session
There was a problem hiding this comment.
Ah, that's the old changelog. I'll fix the copy.
Fixes several issue from initial session-tracking release including: