Expanded support for proxy config from environment variables #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Docs PR incoming for this as well. |
|
@kattrali can I get a review on this for merging? |
| ## | ||
| # Parses and sets proxy from a uri | ||
| def parse_proxy(uri) | ||
| proxy = URI.parse(uri) |
There was a problem hiding this comment.
Would there be any problems if uri was nil at this point?
There was a problem hiding this comment.
Absolutely, however this would only occur if parse_proxy was called with nil, in which case URI would spit out a legible error i.e. **URI::InvalidURIError: bad URI(is not URI?):**
There was a problem hiding this comment.
I could catch and log that error, but I think failing loudly is more valuable in most cases.
kattrali
approved these changes
Apr 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expands setting of
config.proxyoptions to bothENV['http_proxy']andENV['https_proxy']automatically.