Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve DelayedJob max attempts handling #471

Merged
merged 1 commit into from
May 29, 2018
Merged

Improve DelayedJob max attempts handling #471

merged 1 commit into from
May 29, 2018

Conversation

johnnyshields
Copy link
Contributor

  • If the max attempts method returns nil it should fallback to Delayed::Worker.max_attempts
  • Clarify comment

@johnnyshields
Improve DelayedJob max attempts handling
6ba2693 
If the max attempts method returns nil it should fallback to Delayed::Worker.max_attempts
snmaynard
snmaynard approved these changes May 29, 2018
View reviewed changes
Copy link
Contributor

@snmaynard snmaynard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks @johnnyshields!

@snmaynard snmaynard merged commit 2201954 into bugsnag:master May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snmaynard snmaynard snmaynard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnnyshields @snmaynard