Fix Sidekiq metadata: Ensures metadata is attached to notifications

[Cawllec]

Goal

Fix the issue where the Sidekiq integration is clearing request data before it can be attached to a notify call.

[tobyhs]

lib changes look fine, but would it make sense to have tests in spec/integrations/sidekiq_spec.rb that checks whether Sidekiq request data is cleared or not depending on various conditions after calling Bugsnag::Sidekiq#call?

[tobyhs]

possible suggestion, otherwise lgtm

[Cawllec]

Just need the codeclimate allowable complexity to be updated here, I don't have access to that functionality.

[snmaynard]

@kattrali can you make the change?

[javierjulio]

I see this includes a metadata tab for errors that occur within Sidekiq, but only includes msg and queue. Is there a way for Bugsnag to report the worker args when any error occurs within Sidekiq?

[Cawllec]

Hey @javierjulio, the arguments for the job the worker was running with should be present in the msg => args section of the sidekiq metadata.
If that isn't the case, or you aren't seeing that reported, please let us know.

[javierjulio]

@Cawllec no everything is good. 👏🏻 Thanks so much for fixing this! ❤️ I confirmed the fix in development by replicating various errors from production and am now seeing the Sidekiq data in all those cases where we weren't before.