fix: Resolve Ruby deprecation warning (in Ruby 2.7)/error (in 3.0) #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomlongridge
approved these changes
Jan 27, 2020
|
Was this previously picked up in our tests, like failing CI at all? If not it might be good to add deprecation checks to our "latest" test versions (currently 2.7) |
It didn't cause tests to fail, we just happened to notice (as did at least one user). I like the idea of checking for things like this in CI, but I'll raise a separate ticket to address that I think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Resolve Ruby warning generated by Ruby 2.7 (and that become errors in v3).
Tests
Tested using existing Unit and Component tests.
Linked issues
Fixes #580