Add discard_classes option to support strings & regular expressions and deprecate ignore_classes

[imjoehaines]

Goal

The ignore_classes option currently supports Class constants and Proc. Rails has recently deprecated autoloading in initialization (where Bugsnag is usually configured) which makes Class constants unusable. Support for Proc is powerful but un-ergonomic when simply trying to ignore an error by class name

In order to help bring the Ruby notifier in-line with other notifiers I've added discard_classes as a new option and deprecated the existing ignore_classes option. discard_classes works similarly to ignore_classes, with these differences:

1. It accepts String or Regexp rather than Class or Proc
2. It doesn't walk the ancestor chain

Linked issues

Fixes #589

Review

For the submitter, initial self-review:

• Commented on code changes inline explain the reasoning behind the approach
• Reviewed the test cases added for completeness and possible points for discussion
• A changelog entry was added for the goal of this pull request
• Check the scope of the changeset - is everything in the diff required for the pull request?
• This pull request is ready for:
  • Initial review of the intended approach, not yet feature complete
  • Structural review of the classes, functions, and properties modified
  • Final review

For the pull request reviewer(s), this changeset has been reviewed for:

• Consistency across platforms for structures or concepts added or modified
• Consistency between the changeset and the goal stated above
• Internal consistency with the rest of the library - is there any overlap between existing interfaces and any which have been added?
• Usage friction - is the proposed change in usage cumbersome or complicated?
• Performance and complexity - are there any cases of unexpected O(n^3) when iterating, recursing, flat mapping, etc?
• Concurrency concerns - if components are accessed asynchronously, what issues will arise
• Thoroughness of added tests and any missing edge cases
• Idiomatic use of the language

[pic]

support of Proc would still be useful so in the proc I could check is_a? and still be able to group the exceptions that I want to ignore with a common ancestor. Is there any chance that it will be added again?

[snmaynard]

You should be able to use the newly added on_error Procs to handle that

[ngan]

So is the suggested way to use on_error for walking ancestors? Or continue using adding a Proc to ignore_classes?

[imjoehaines]

So is the suggested way to use on_error for walking ancestors? Or continue using adding a Proc to ignore_classes?

Yeah I'd recommend using on_error for that. If you're already using ignore_classes then it will continue to work for now, but you'll need to migrate eventually