-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve payload cleaning performance #601
Merged
Merged
Commits on Jun 24, 2020
-
Improve performance of cleaning objects
This is a first iteration of improving how we clean objects when preparing to JSON encode them Currently we iterate over the payload multiple times; sometimes to clean up encoding errors/recursion and other times to filter sensitive data Ideally we should be iterating over the payload once, which is slightly complicated because we should only be filtering parts of the payload (the metadata and breadcrumb metadata)
Configuration menu - View commit details
-
Copy full SHA for 9f404dc - Browse repository at this point
Copy the full SHA 9f404dcView commit details -
Move some tests to report_spec
Helper no longer breaks recursion in 'trim_if_needed', so these tests no longer apply there. However we are still breaking recursion and so can test the same thing elsewhere
Configuration menu - View commit details
-
Copy full SHA for 3888357 - Browse repository at this point
Copy the full SHA 3888357View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6907d59 - Browse repository at this point
Copy the full SHA 6907d59View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4d5f7b5 - Browse repository at this point
Copy the full SHA 4d5f7b5View commit details -
Provide Cleaner with scopes that it should filter
For example, in this hash: { a: { b: 'c' } } 'c' lives in scope 'a.b' and so should only be filtered if Cleaner is given 'a.b' in its 'scopes_to_filter'
Configuration menu - View commit details
-
Copy full SHA for 3275fe6 - Browse repository at this point
Copy the full SHA 3275fe6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5762b38 - Browse repository at this point
Copy the full SHA 5762b38View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7d9b8c6 - Browse repository at this point
Copy the full SHA 7d9b8c6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0699f90 - Browse repository at this point
Copy the full SHA 0699f90View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1203022 - Browse repository at this point
Copy the full SHA 1203022View commit details -
Configuration menu - View commit details
-
Copy full SHA for e87761b - Browse repository at this point
Copy the full SHA e87761bView commit details
Commits on Jul 6, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 86d7ce1 - Browse repository at this point
Copy the full SHA 86d7ce1View commit details
Commits on Jul 7, 2020
-
Make Cleaner a shared instance
This exposed a pretty big regression where filters wouldn't match when they should have. This was caused by us filtering the entire report object in one go, which means the scopes were nested deeper than they were before Previously we filtered the events.metaData directly, so scopes would not include 'events.metaData' and therefore a filter of 'foo' would match 'events.metaData.foo'. Now that we filter the entire report, if a filter relied on 'deep_filters', it would apply and so things that should be redacted wouldn't have been To solve this, we strip each 'scope_to_filter' from the scope before matching it, if deep_filters are enabled The tests passed before this change because we set 'scopes_to_filter' in each test. Now that the instance is shared, the scopes are fetched from the Configuration so this isn't possible and it exposed the bug The tests now cover this case, because they can't set 'scopes_to_filter' directly anymore, so they are testing that the filters they're using match with the Configuration's 'scopes_to_filter'
Configuration menu - View commit details
-
Copy full SHA for 8c669ae - Browse repository at this point
Copy the full SHA 8c669aeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5700938 - Browse repository at this point
Copy the full SHA 5700938View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.