Improve stacktrace file path resolving performance by avoiding Pathname #602
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
This PR improves the performance of resolving relative file paths when gathering the stacktrace for errors, by using
File.realpath
instead ofPathname.realpath
. The two methods are identical, except thePathname
module wraps the return value in aPathname
object. We immediately convert thePathname
object to a string anyway, so there's no gain in usingPathanme
for thisWe still use
Pathname
for checking if the file path is relative, as it doesn't have a direct replacement in theFile
module and I'd like to improve our tests around this area before trying to replace itLinked issues
Related to #481
Review
For the submitter, initial self-review:
For the pull request reviewer(s), this changeset has been reviewed for: