Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up file path resolution when processing stacktraces #603

Merged
merged 1 commit into from
Jul 15, 2020

Commits on Jul 15, 2020

  1. Remove the check for a relative path

    This isn't a _huge_ perf boost, but every little helps :^)
    
    In the old Pathname method, this if was useful because it was quicker
    to skip files that were already resolved, assuming there was a mix of
    relative and absolute paths
    
    With File.realpath, however, it's quicker to just run the function as
    it does nothing if the path is already resolved. This is roughtly
    equal in terms of performance to using the new File.absolute_path?
    method (they are so close in benchmarks that it's essentially noise)
    imjoehaines committed Jul 15, 2020
    Configuration menu
    Copy the full SHA
    f14f39a View commit details
    Browse the repository at this point in the history