Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAT-3702] Report runtime versions for Delayed Job, Mailman and Shoryuken #620

Merged
merged 2 commits into from
Aug 3, 2020

Conversation

imjoehaines
Copy link
Contributor

@imjoehaines imjoehaines commented Jul 31, 2020

Goal

This PR adds runtime versions for:

  • Delayed Job
  • Mailman
  • Shoryuken

Mailman & Shoryuken are straightforward, but Delayed Job doesn't have a constant with its version in so instead we have to read it from the loaded Gems

Review

For the submitter, initial self-review:

  • Commented on code changes inline explain the reasoning behind the approach
  • Reviewed the test cases added for completeness and possible points for discussion
  • A changelog entry was added for the goal of this pull request
  • Check the scope of the changeset - is everything in the diff required for the pull request?
  • This pull request is ready for:
    • Initial review of the intended approach, not yet feature complete
    • Structural review of the classes, functions, and properties modified
    • Final review

For the pull request reviewer(s), this changeset has been reviewed for:

  • Consistency across platforms for structures or concepts added or modified
  • Consistency between the changeset and the goal stated above
  • Internal consistency with the rest of the library - is there any overlap between existing interfaces and any which have been added?
  • Usage friction - is the proposed change in usage cumbersome or complicated?
  • Performance and complexity - are there any cases of unexpected O(n^3) when iterating, recursing, flat mapping, etc?
  • Concurrency concerns - if components are accessed asynchronously, what issues will arise
  • Thoroughness of added tests and any missing edge cases
  • Idiomatic use of the language

@imjoehaines imjoehaines changed the title Report runtime versions for Delayed Job, Mailman and Shoryuken [PLAT-3702] Report runtime versions for Delayed Job, Mailman and Shoryuken Jul 31, 2020
@imjoehaines imjoehaines marked this pull request as ready for review August 3, 2020 08:07
lib/bugsnag/integrations/delayed_job.rb Outdated Show resolved Hide resolved
This adds runtime versions for:
- Delayed Job
- Mailman
- Shoryuken

Mailman & Shoryuken are straightforward, but Delayed Job doesn't have
a constant with its version in. Instead we can read it from the loaded
Gems
@imjoehaines imjoehaines merged commit fb4adbd into next Aug 3, 2020
@imjoehaines imjoehaines deleted the more-runtime-versions branch August 3, 2020 09:05
@imjoehaines imjoehaines mentioned this pull request Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants