Delay JSON serialization until delivery when using the thread queue delivery method #623
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
This PR adds a new method that delivery methods can implement in order to delay serialization of the
Bugnsag::Report
object. This is used by the thread queue delivery method to shift some work off of the main threadThis works by passing a proc that will serialize the Report rather than the serialized Report itself, this way the delivery method doesn't have to know how things are serialized only how to get the serialized value. This is a bit less flexible than passing the Report directly, but I don't think it makes sense for delivery methods to use different serialization
Review
For the submitter, initial self-review:
For the pull request reviewer(s), this changeset has been reviewed for: