Increase timestamp resolution to include milliseconds #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imjoehaines
force-pushed
the
increase-timestamp-resolution
branch
from
ec5b199
to
8e730a5
Compare
imjoehaines
force-pushed
the
increase-timestamp-resolution
branch
from
8e730a5
to
c9f142d
Compare
imjoehaines
force-pushed
the
increase-timestamp-resolution
branch
from
c9f142d
to
959025b
Compare
kattrali
approved these changes
Oct 22, 2020
Breadcrumbs now have milliseconds included, which allows for the Bugsnag app to display the timestamps more accurately
imjoehaines
force-pushed
the
increase-timestamp-resolution
branch
from
a9f82ea
to
55c6806
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
In order for the Bugsnag app to report breadcrumb times more accurately, we need to send timestamps with milliseconds. Other timestamps have also been updated for consistency, but shouldn't have any impact. The session tracker has not been updated as it intentionally rounds to the minute
Testing
Additional unit tests added to check the timestamps are as expected. Existing MR tests also check the timestamps against a regex, which didn't need to be updated