Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugsnag gem crashes when used with an older mongo gem (1.12) #652

Merged
merged 1 commit into from
Mar 26, 2021

Conversation

isabanin
Copy link
Contributor

Trying to use bugsnag gem together with mongo 1.12 raises the following error during application boot time: uninitialized constant Mongo::Monitoring (NameError).

Goal

To make sure Bugsnag can be used with applications that are stuck with an older mongo version, even if Mongo integration cannot be used in that case.

Changeset

I added a check to make sure Mongo::Monitoring class is defined before Bugsnag tries to use it. Pretty simple.

Testing

Tested manually.

Trying to use bugsnag gem together with mongo gem 1.12 raises the following error on boot: uninitialized constant Mongo::Monitoring (NameError).
@yousif-bugsnag
Copy link

Hey @isabanin, thanks for the PR! We'll look at reviewing/merging this when priorities allow.

@yousif-bugsnag yousif-bugsnag added backlog We hope to fix this feature/bug in the future bug Confirmed bug labels Mar 18, 2021
@imjoehaines imjoehaines changed the base branch from master to next March 26, 2021 15:14
Copy link
Contributor

@imjoehaines imjoehaines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@imjoehaines imjoehaines merged commit 5f0e0ea into bugsnag:next Mar 26, 2021
imjoehaines added a commit that referenced this pull request Mar 29, 2021
@imjoehaines imjoehaines mentioned this pull request Mar 29, 2021
@johnkiely1 johnkiely1 added released This feature/bug fix has been released and removed bug Confirmed bug labels Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog We hope to fix this feature/bug in the future released This feature/bug fix has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants