Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Methods to be used as callbacks / middleware #662

Closed
wants to merge 2 commits into from
Closed

Allow Methods to be used as callbacks / middleware #662

wants to merge 2 commits into from

Conversation

odlp
Copy link
Contributor

@odlp odlp commented Jun 11, 2021

Goal

Allow integrators to provide a Method (or anything responding to #call) for on-error callbacks / middleware.

Resolves #661

Design

Changeset

Testing

New specs in spec/on_error_spec.rb

@yousif-bugsnag
Copy link

Hi @odlp thanks for the PR! We'll look to review this as soon as priorities allow.

@yousif-bugsnag yousif-bugsnag added backlog We hope to fix this feature/bug in the future feature request Request for a new feature labels Jun 11, 2021
@imjoehaines
Copy link
Contributor

Thanks for the PR @odlp!

I'll merge this in #665 as our tests need to run on Ruby 1.9 so needed a small change

@odlp odlp deleted the allow-method-callbacks branch June 16, 2021 15:24
@imjoehaines imjoehaines mentioned this pull request Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog We hope to fix this feature/bug in the future feature request Request for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow methods + lambdas for on_error callbacks / middleware
3 participants