Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add on_breadcrumb callbacks to replace before_breadcrumb_callbacks #686

Merged
merged 6 commits into from
Aug 23, 2021
Merged

Add on_breadcrumb callbacks to replace before_breadcrumb_callbacks #686

merged 6 commits into from
Aug 23, 2021

Commits on Aug 20, 2021

  1. Add OnBreadcrumbCallbackList class 

    This manages and calls any registered on_breadcrumb callbacks
    @imjoehaines
    imjoehaines committed Aug 20, 2021
    Configuration menu
    Copy the full SHA
    f4030f9 View commit details
    Browse the repository at this point in the history

  2. Handle errors raised in on_breadcrumb callbacks

    @imjoehaines
    imjoehaines committed Aug 20, 2021
    Configuration menu
    Copy the full SHA
    c4de39f View commit details
    Browse the repository at this point in the history

  3. Move before_breadcrumb tests to a new describe

    @imjoehaines
    imjoehaines committed Aug 20, 2021
    Configuration menu
    Copy the full SHA
    21f459b View commit details
    Browse the repository at this point in the history

  4. Add add and remove on_breadcrumb methods

    @imjoehaines
    imjoehaines committed Aug 20, 2021
    Configuration menu
    Copy the full SHA
    99d7729 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2021

  1. Call on_breadcrumb callbacks in leave_breadcrumb

    @imjoehaines
    imjoehaines committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    056d110 View commit details
    Browse the repository at this point in the history

  2. Update changelog

    @imjoehaines
    imjoehaines committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    7545b01 View commit details
    Browse the repository at this point in the history