Support Exception#detailed_message
#761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imjoehaines
changed the title
Exception#detailed_message
imjoehaines
force-pushed
the
support-exception-detailed-message
branch
from
a9306c6
to
c38675c
Compare
imjoehaines
force-pushed
the
support-exception-detailed-message
branch
from
c38675c
to
164b76a
Compare
This was added in Ruby 3.2 for things like 'did_you_mean' that annotate existing exception messages Currently the annotations are included in Exception#message, but when Ruby 3.2 releases they will move to Exception#detailed_message so we need to use the new method to keep the existing behaviour
This shouldn't happen in practice but we should be safe to protect against invalid definitions of detailed_message It's also possible someone has implemented this method on Ruby versions < 3.2 where there isn't an expectation to have a highlight parameter as it wasn't a standard Exception method
imjoehaines
force-pushed
the
support-exception-detailed-message
branch
from
164b76a
to
8a34d93
Compare
Cawllec
approved these changes
Dec 19, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
This was added in Ruby 3.2 for things like 'did_you_mean' that annotate existing exception messages
Currently the annotations are included in
Exception#message, but when Ruby 3.2 releases they will move toException#detailed_messageso we need to use the new method to keep the existing behaviour