Redact URLs in automatic Rails breadcrumbs #806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomlongridge
approved these changes
Dec 18, 2023
Merged
timdiggins
reviewed
Jan 11, 2024
| filtered_data[:path] = Bugsnag.cleaner.clean_url(data[:path]) if data.key?(:path) | ||
|
|
||
| when "redirect_to.action_controller" | ||
| filtered_data[:location] = Bugsnag.cleaner.clean_url(data[:location]) if data.key?(:location) |
There was a problem hiding this comment.
This causes an error to surface in the app if the data[:location] (ie. the redirect_to url) is a badly formed, but actually in practice working URL, such as: https://example.com/some path with spaces -- browsers (and even rack:test) will automatically convert this to https://example.com/some path%20with%20spaces but URI("https://example.com/some path with spaces") (as used at https://github.com/bugsnag/bugsnag-ruby/blob/master/lib/bugsnag/cleaner.rb#L30) will raise URI::InvalidURIError
There was a problem hiding this comment.
Thanks, @timdiggins! I'll try to get a release out with a fix early next week
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.