Fix compatibility with Ruby 3.4-dev #815
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @k0kubun Thank you for reaching out and adding this PR. When priorities allow we will review this and look to merge. We will be sure to keep you updated here on this thread. |
imjoehaines
added a commit
that referenced
this pull request
Mar 15, 2024
mclack
added
released
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Parse backtraces correctly with Ruby 3.4-dev
Design
This PR deals with Ruby 3.4's backtrace incompatibility introduced at ruby/ruby#9608.
They used
[`']for fixing existing tests too.Changeset
Fixed
BACKTRACE_LINE_REGEXto parse backtraces which use two's.Testing
Reusing existing tests on Ruby 3.4-dev should be enough. Using this branch fixed our test cases.