Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include warden scope in user info #821

Merged
merged 4 commits into from
May 17, 2024
Merged

Conversation

javierjulio
Copy link
Contributor

Goal

Closes #777

The default user metadata includes id but without the Warden scope, if you have multiple user types, for example: User and AdminUser, it wouldn't be possible to know who's who when removing the default fields which are PII.

Design

Simple approach as Warden scope is already used to determine the user object in this case, so the objective is to just include the scope value as another user field.

Changeset

Just adds a warden_scope key to the user object.

Testing

Copy link
Contributor

@imjoehaines imjoehaines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @javierjulio!

@imjoehaines imjoehaines changed the base branch from master to next May 17, 2024 08:30
@imjoehaines imjoehaines merged commit e66f7e9 into bugsnag:next May 17, 2024
66 of 67 checks passed
@imjoehaines imjoehaines mentioned this pull request May 23, 2024
@javierjulio javierjulio deleted the patch-1 branch June 25, 2024 22:22
@javierjulio javierjulio restored the patch-1 branch June 25, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set warden scope on user data
2 participants