Only read Rack request body if it's rewindable #829
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Rack 3 made it possible for the request body to not be rewindable, meaning it can only be read once
We rely on reading the request body for two pieces of metadata,
request.params
(if it's a form request) andrequest.body
. These won't be set if the body has already been read, which is quite likelyWith
request.params
we will only read the query string if the request cannot be rewoundWith
request.body
we will not read it at all if the request cannot be rewound