Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic IP for trusted_ips #291

Open
bugy opened this issue Apr 14, 2020 · 4 comments
Open

Dynamic IP for trusted_ips #291

bugy opened this issue Apr 14, 2020 · 4 comments
Labels

Comments

@bugy
Copy link
Owner

bugy commented Apr 14, 2020

I found the problem:
In my conf file i had : "trusted_ips": "*" and when i added the ip of the proxy like "trusted_ips": ["172.17.0.6"] it worked perfectly.

Now my problem is that the ip of the proxy is not static because is inside of a kubernetes pod meaning that each time the pod is reloaded a new static ip is assigned, however i can access the pod using dns "myproxy" like in http://myproxy:5000/endpoint hence i tried "trusted_ips": ["myproxy"] but sadly didn't work

Is there any form for use the proxy auth without set ip? or use the dns ?

Originally posted by @oktorok in #289 (comment)

@bugy bugy added the feature label Apr 14, 2020
@bugy
Copy link
Owner Author

bugy commented Nov 18, 2020

Hi @oktorok recently I implemented #331, do you think it would work for you?

@bugy bugy added the resolved label Apr 5, 2021
@bugy bugy added this to the 1.16.0 milestone Apr 5, 2021
@bugy bugy closed this as completed Apr 5, 2021
@bugy bugy removed the resolved label Apr 5, 2021
@bugy bugy removed this from the 1.16.0 milestone Apr 5, 2021
@bugy bugy reopened this Apr 5, 2021
@Nindaleth
Copy link

Maybe I'm doing something wrong, but I set up a subnet for both trusted IPs and admin IPs and I can't get it to work. I have the following configured:

{
  "access": {
    "admin_users": ["10.0.0.0/8"],
    "trusted_ips": ["10.0.0.0/8"]
  }
}

I can access the main page and run scripts, but I'm seeing the GitHub icon instead of a gear, the admin page gives 403. This is on a network where everyone is logging in via VPN, the client IP is randomly assigned from a relatively large pool so I can't configure just a few specific addresses. Is this approach unsupported?

@bugy
Copy link
Owner Author

bugy commented Jun 28, 2021

admin_users cannot be a subnet. If you want to give admin access to everyone, you can use "admin_users": ["*"]

@Nindaleth
Copy link

OK, with the "admin_users": ["*"] I'm all set for my use case. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants