-
-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trusted IPs allow to use * or subnet #331
Comments
Hi @Nottt, I think subnets would be a nice approach |
Hey @bugy any news around this? I have been hit multiple times in the last weeks with this issue. I can just get the ip from the logs and change conf.json and restart it, but It seems I'm suffering the Murphy's law and this only happens when I'm away for a extended time and then script server is offline only because of this. If this is marked as won't fix, then I'll find a way to give a permanent static to my nginx container... |
Hi, it's definitely will be implemented, not sure about the estimate
though. Will try to find some time for it in the next 2 weeks
ad90xa0-aa <notifications@github.com> schrieb am Di., 29. Sept. 2020, 08:36:
… Hey @bugy <https://github.com/bugy> any news around this? I have been hit
multiple times in the last weeks with this issue.
I can just get the ip from the logs and change conf.json and restart it,
but It seems I'm suffering the Murphy's law and this only happens when I'm
away for a extended time and then script server is offline only because of
this.
If this is marked as won't fix, then I'll find a way to give a permanent
static to my nginx container...
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#331 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJXPJKEJOHNCU3VLUNNQX3SIF575ANCNFSM4QNNMP7A>
.
|
Hi. I can't use computers much recently because of health related issues. And my script server is getting this a lot more now that for some reason docker is restarting by itself on my server. What do you think of a bounty of $50 for this issue for this before monday ? |
Hi, i got your priority :) I'll do it (dev version), without a bounty
1 question, do you think a mask would work for you? Like not allowing
everything, but only limited range of IPs
ad90xa0-aa <notifications@github.com> schrieb am Sa., 10. Okt. 2020, 11:17:
… Hi. I can't use computers much recently because of health related issues.
And my script server is getting this a lot more now that for some reason
docker is restarting by itself on my server.
What do you think of a bounty of $50 for this issue for this before monday
?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#331 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJXPJIGWFE5635V6PJSL2DSKAREHANCNFSM4QNNMP7A>
.
|
I think subnet is enough. Since most docker setups will have dynamic ips, but always from the same subnet. |
Or did you mean something like 178.18.0.* ? If by that, I think that would be good too |
Just standard subnet syntax, like 192.168.1.0/8
ad90xa0-aa <notifications@github.com> schrieb am Sa., 10. Okt. 2020, 11:52:
… Or did you mean something like 178.18.0.* ? If by that, I think that would
be good too
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#331 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJXPJMQGXHKSGPVKSOCFO3SKAVHBANCNFSM4QNNMP7A>
.
|
Yes that would be perfect too |
Hi @Nottt I added support for ip4 subnets, could you try it, please? |
It seems to be working as expected. Give me your btc wallet |
Hi, nice to hear that!
I'm not going to take money from contributors :)
ad90xa0-aa <notifications@github.com> schrieb am Mo., 12. Okt. 2020, 07:19:
… It seems to be working as expected. Give me your btc wallet
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#331 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJXPJM423NYETEE52A27HDSKKGVDANCNFSM4QNNMP7A>
.
|
Are you sure about that ? I'd be happy to donate :) |
Absolutely! I prefer "donations" by contribution :)
ad90xa0-aa <notifications@github.com> schrieb am Mo., 12. Okt. 2020, 08:13:
… Are you sure about that ? I'd be happy to donate :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#331 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJXPJP6DJM47G6NAT3DZTLSKKM7VANCNFSM4QNNMP7A>
.
|
What do you mean ? |
For me, an implemented feature or some utility script is more important,
than money.
And you already did it by providing extended docker image
ad90xa0-aa <notifications@github.com> schrieb am Mo., 12. Okt. 2020, 08:19:
… What do you mean ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#331 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJXPJPTTNOV44LF3H7RMA3SKKNWNANCNFSM4QNNMP7A>
.
|
Oh ok thank you! I didn't think people were using my container already lol. Your software is amazing as always |
Thanks for the improvement! Would be lovely to see this in the server config example. I'm just going to drop another useful keyword here to improve searchability - CIDR notation. |
Hi @Nindaleth, this is already in the example for |
Aha! I missed that one, sorry about that. |
In my docker setup, each container get an random IP when it starts. It would require me to do a lot of modifications to be able to give my nginx container a static IP so the trusted ip work.
I suggest 2 options
Currently, every time my nginx container get a new IP I have to edit the configuration file to add the new ip...
The text was updated successfully, but these errors were encountered: