Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trusted IPs allow to use * or subnet #331

Closed
Nottt opened this issue Aug 27, 2020 · 20 comments
Closed

Trusted IPs allow to use * or subnet #331

Nottt opened this issue Aug 27, 2020 · 20 comments

Comments

@Nottt
Copy link

Nottt commented Aug 27, 2020

In my docker setup, each container get an random IP when it starts. It would require me to do a lot of modifications to be able to give my nginx container a static IP so the trusted ip work.

I suggest 2 options

  1. Allow to use * as the trusted ip, meaning any IP will be ok
  2. Allow to use a subnet instead of a specific IP like 178.18.0.0/24

Currently, every time my nginx container get a new IP I have to edit the configuration file to add the new ip...

@bugy
Copy link
Owner

bugy commented Aug 28, 2020

Hi @Nottt, I think subnets would be a nice approach

@bugy bugy added the feature label Aug 28, 2020
@Nottt
Copy link
Author

Nottt commented Sep 29, 2020

Hey @bugy any news around this? I have been hit multiple times in the last weeks with this issue.

I can just get the ip from the logs and change conf.json and restart it, but It seems I'm suffering the Murphy's law and this only happens when I'm away for a extended time and then script server is offline only because of this.

If this is marked as won't fix, then I'll find a way to give a permanent static to my nginx container...

@bugy
Copy link
Owner

bugy commented Sep 29, 2020 via email

@Nottt
Copy link
Author

Nottt commented Oct 10, 2020

Hi. I can't use computers much recently because of health related issues. And my script server is getting this a lot more now that for some reason docker is restarting by itself on my server.

What do you think of a bounty of $50 for this issue for this before monday ?

@bugy
Copy link
Owner

bugy commented Oct 10, 2020 via email

@Nottt
Copy link
Author

Nottt commented Oct 10, 2020

I think subnet is enough. Since most docker setups will have dynamic ips, but always from the same subnet.

@Nottt
Copy link
Author

Nottt commented Oct 10, 2020

Or did you mean something like 178.18.0.* ? If by that, I think that would be good too

@bugy
Copy link
Owner

bugy commented Oct 10, 2020 via email

@Nottt
Copy link
Author

Nottt commented Oct 10, 2020

Yes that would be perfect too

@bugy
Copy link
Owner

bugy commented Oct 10, 2020

Hi @Nottt I added support for ip4 subnets, could you try it, please?

@Nottt
Copy link
Author

Nottt commented Oct 12, 2020

It seems to be working as expected. Give me your btc wallet

@bugy
Copy link
Owner

bugy commented Oct 12, 2020 via email

@Nottt
Copy link
Author

Nottt commented Oct 12, 2020

Are you sure about that ? I'd be happy to donate :)

@bugy
Copy link
Owner

bugy commented Oct 12, 2020 via email

@Nottt
Copy link
Author

Nottt commented Oct 12, 2020

What do you mean ?

@bugy
Copy link
Owner

bugy commented Oct 12, 2020 via email

@Nottt
Copy link
Author

Nottt commented Oct 12, 2020

Oh ok thank you! I didn't think people were using my container already lol. Your software is amazing as always

@bugy bugy added the resolved label Apr 5, 2021
@bugy bugy added this to the 1.16.0 milestone Apr 5, 2021
@bugy bugy closed this as completed Apr 5, 2021
@Nindaleth
Copy link

Thanks for the improvement! Would be lovely to see this in the server config example. I'm just going to drop another useful keyword here to improve searchability - CIDR notation.

@bugy
Copy link
Owner

bugy commented Jun 25, 2021

Hi @Nindaleth, this is already in the example for trusted_ips section: https://github.com/bugy/script-server/wiki/Server-configuration#--trusted_ips

@Nindaleth
Copy link

Aha! I missed that one, sorry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants