Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow json comments #415

Merged
merged 9 commits into from
Jun 24, 2021
Merged

Allow json comments #415

merged 9 commits into from
Jun 24, 2021

Conversation

brunomgalmeida
Copy link
Contributor

This may be useful, to document scripts or features

@bugy
Copy link
Owner

bugy commented Mar 24, 2021

Hi @brunomgalmeida I think this is a helpful feature.
However, I prefer to avoid adding extra dependencies without extra need for several reasons:

  1. It breaks backward compatibility somehow (after installing new version, the server won't start)
  2. Some dependencies might introduce security risk or just some bugs, and being not very popular, the risk is higher
  3. I would like to keep machines as lightweight as possible

Copy link
Owner

@bugy bugy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes! I left a couple of comments

Also, I think these places should be updated as well:

  • auth_ldap:255
  • config_service:192
  • script_config:246
  • schedule_service:38

samples/conf.json Outdated Show resolved Hide resolved
src/migrations/migrate.py Show resolved Hide resolved
src/utils/custom_json.py Outdated Show resolved Hide resolved
src/utils/custom_json.py Outdated Show resolved Hide resolved
src/model/server_conf.py Show resolved Hide resolved
src/config/config_service.py Show resolved Hide resolved
Copy link
Owner

@bugy bugy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bugy bugy merged commit 61319a0 into bugy:master Jun 24, 2021
@bugy bugy added the feature label Jun 24, 2021
@bugy bugy added this to the 1.17.0 milestone Jun 24, 2021
@bugy bugy added the resolved label Dec 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants