chore(elixir): improve API exposed via NIF calls #1282
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feniks65
force-pushed
the
wwais/elixir_improve_vault
branch
from
f638294
to
d9d7714
Compare
feniks65
force-pushed
the
wwais/elixir_improve_vault
branch
from
d9d7714
to
2df1f39
Compare
|
@feniks65 sorry for not replying to this sooner. These changes are exactly the direction I was hoping for, thank you for working on them 🙏 I'll work on merging what you have so far, in a couple of hours. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Properly rename parameters for
Ockam.VaultandOckam.Vault.Software.@mrinalwadhwa
I wanted to at least address some of the work that should be done for #1090 issue.
Is this is how you wanted to have it? I have just started it. Still I need to add more docs and
@specattributes.I am just asking if I am on the right path?