Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix user id env variable in ockam-builder docker run cmd #1424

Closed

Conversation

psinghal20
Copy link
Contributor

Proposed Changes

This PR changes the env variable used in the Ockam-builder docker run command used for building the project.

@mrinalwadhwa
Copy link
Member

Hey @psinghal20 changes look great, Thank you for sending the PR ❤️

Before we can merge, a couple of small requests:

  1. Could you sign the commit
  2. Could you accept our CLA.

Read the CLA at
https://www.ockam.io/learn/how-to-guides/contributing/cla/

To accept the CLA please send a different PR to our contributors repo indicating that you accept the CLA by adding your Git/Github details in a row at the end of the CONTRIBUTORS.csv file:
https://github.com/ockam-network/contributors/blob/master/CONTRIBUTORS.csv

Looking forward to merging your first contribution!!

… run cmd

Signed-off-by: Pratyush Singhal <psinghal20@gmail.com>
@psinghal20
Copy link
Contributor Author

Done! Here is my CLA PR: https://github.com/ockam-network/contributors/pull/17
I have also updated the commit.

@mrinalwadhwa
Copy link
Member

Thank you, I merged 7f5d792 after a minor change to the commit message scope based on our conventions.

Congratulations on you first Ockam contribution!! 🎉 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants