Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rust): Rename Ockam Command MessageFormat to OutputFormat #3073

Closed

Conversation

edbastelli
Copy link
Contributor

Current Behavior

ockam command takes -m or --message-format <MESSAGE_FORMAT> options

Proposed Changes

change options to -f or --format <OUTPUT_FORMAT>
change enum name to OutputFormat
change varialb ename to output_format
fixes #2990

Checks

@edbastelli edbastelli requested a review from a team as a code owner July 30, 2022 19:06
Rename Ockam Command MessageFormat to OutputFormat
change variable message_format to output_format
edit clap attribute arguments to accept -f and --format options
@mrinalwadhwa
Copy link
Member

@edbastelli thank you. The changes look great 👍.

I'm away, will merge later today.

@mrinalwadhwa mrinalwadhwa mentioned this pull request Jul 30, 2022
@mrinalwadhwa
Copy link
Member

Merged in #3074.
Thank you for an awesome first contribution 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename -m, --message-format <MESSAGE_FORMAT> to -f, --format <OUTPUT_FORMAT>
2 participants