Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rust): add disable-content-encryption flag to the kafka-inlet create command #8171

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

davide-baldo
Copy link
Member

No description provided.

@davide-baldo davide-baldo force-pushed the davide-baldo/encrypt-kafka-messages-flag branch from 4db25d1 to 7d47760 Compare June 13, 2024 18:24
@davide-baldo davide-baldo changed the title feat(rust): add encrypt-content flag to the kafka-inlet create command feat(rust): add disable-content-encryption flag to the kafka-inlet create command Jun 13, 2024
@davide-baldo davide-baldo force-pushed the davide-baldo/encrypt-kafka-messages-flag branch from 7d47760 to 9dd8673 Compare June 13, 2024 18:25
@davide-baldo davide-baldo marked this pull request as ready for review June 14, 2024 16:22
@davide-baldo davide-baldo requested a review from a team as a code owner June 14, 2024 16:22
Copy link
Member

@polvorin polvorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC the scenario where this is useful is if client can't connect to kafka directly, but uses a project relay to reach it. Messages won't be encrypted on kafka , but in-flight messages between the two networks (client and kafka one) will be as they pass through the project relay?

@davide-baldo
Copy link
Member Author

IIUC the scenario where this is useful is if client can't connect to kafka directly, but uses a project relay to reach it. Messages won't be encrypted on kafka , but in-flight messages between the two networks (client and kafka one) will be as they pass through the project relay?

Exactly

@davide-baldo davide-baldo added this pull request to the merge queue Jun 18, 2024
Merged via the queue into develop with commit 44e2336 Jun 18, 2024
26 checks passed
@davide-baldo davide-baldo deleted the davide-baldo/encrypt-kafka-messages-flag branch June 18, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants