Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: telemetry data export via a secure channel #8792

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

etorreborre
Copy link
Member

@etorreborre etorreborre commented Feb 6, 2025

This PR allows telemetry data (logs and spans) to be exported via a secure channel to the authority node.
This is the first step for exporting telemetry data via a secure channel, the next step will be to export it via the project node.

gRPC data interception

When a project is ready, the log and span exporters are set with a gRPC client which packs the gRPC requests into Ockam messages.

Those messages are sent to a HttpForwarder worker which deserializes the requests and forwards them to an Opentelemetry collector endpoint.

Documentation

I started a telemetry.md document to describe the different options which can be used to export telemetry data.

TcpTransport

The creation of a TcpTransport with the TcpTransport::create(ctx: &Context) method now checks if the transport has not already been created. If it has been created, it returns the same TcpTransport instead of returning a new one which would have a new internal registry and potentially lose some data.

This avoids the passing of both the Context and a TcpTransport when creating the SecureClient that will be used to send telemetry data.

Dependencies upgrades

This PR also upgrades the opentelemetry crates since there were recent breaking changes and more are coming up.

@etorreborre etorreborre self-assigned this Feb 6, 2025
@etorreborre etorreborre force-pushed the etorreborre/feat/opentelemetry-traces-interception branch 6 times, most recently from f1af868 to 8c0abb3 Compare February 10, 2025 15:31
@etorreborre etorreborre force-pushed the etorreborre/feat/opentelemetry-traces-interception branch from 8c0abb3 to 63eb25b Compare February 10, 2025 15:34
@etorreborre etorreborre marked this pull request as ready for review February 10, 2025 15:52
@etorreborre etorreborre requested a review from a team as a code owner February 10, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant