Fixed repo permissions check

[mdio]

While testing #15 I
Unfortunately the fix for issue #15 doesn't work correctly because when NetworkUtils.checkAvailabilityOfGitHubWithCurrentSettingsOfProject is called, success is not evaluated (see Line 121 of StatusProjectViewController.swift).
Because the error in this case is empty as well (completion(success: hasPermissions, error: nil)) the success code path is taken.

I rewrote the check in the controller to prevent this in the future (though I'm not totally happy with the code duplication for the logging).
I also added errors for all cases where success is false.

[czechboy0]

You can do something like Log.error(error.description ?? "Unknown error") to get the same behavior without the duplication.

[czechboy0]

Wow great catch! Yeah that definitely looks wrong, I was under the impression I used the hasPermission boolean, but instead I only looked at the error. I like the way you fixed it, so if you can just fix the duplication re my comment, I'll merge it right away (ignore Builda screaming that there was a build error, I just realized it can't yet do cross-fork pull requests - #23).

Thanks!

[czechboy0]

Result of integration 1
Perfect build! All 7 tests passed. 👍

[czechboy0]

Result of integration 2
Perfect build! All 7 tests passed. 👍

[mdio]

@czechboy0 Thanks. Learned about the nil coalescing operator. :)

[czechboy0]

:) Thank you for fixing the bug. Merging.