Enterprise GitHub using Personal Tokens #251
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,83 @@ | ||
| // | ||
| // EnterpriseGitHubSourceTests.swift | ||
| // Buildasaur | ||
| // | ||
| // Created by Rachel Caileff on 3/8/16. | ||
| // Copyright © 2016 Honza Dvorsky. All rights reserved. | ||
| // | ||
|
|
||
| import Cocoa | ||
| import XCTest | ||
| @testable import BuildaGitServer | ||
| import BuildaUtils | ||
|
|
||
| class EnterpriseGitHubSourceTests: XCTestCase { | ||
|
|
||
| var github: GitHubServer! | ||
|
|
||
| override func setUp() { | ||
| super.setUp() | ||
|
|
||
| self.github = GitServerFactory.server(.EnterpriseGitHub(host: "git.mycompany.com"), auth: nil) as! GitHubServer // TODO: fill in accessible enterprise github host | ||
| } | ||
|
|
||
| override func tearDown() { | ||
|
|
||
| self.github = nil | ||
|
|
||
| super.tearDown() | ||
| } | ||
|
|
||
| func tryEndpoint(method: HTTP.Method, endpoint: GitHubEndpoints.Endpoint, params: [String: String]?, completion: (body: AnyObject!, error: NSError!) -> ()) { | ||
|
|
||
| let expect = expectationWithDescription("Waiting for url request") | ||
|
|
||
| let request = try! self.github.endpoints.createRequest(method, endpoint: endpoint, params: params) | ||
|
|
||
| self.github.http.sendRequest(request, completion: { (response, body, error) -> () in | ||
|
|
||
| completion(body: body, error: error) | ||
| expect.fulfill() | ||
| }) | ||
|
|
||
| waitForExpectationsWithTimeout(10, handler: nil) | ||
|
There was a problem hiding this comment. Isn't this going to fail outside of your network? There was a problem hiding this comment. The tests are commented out. The helper functions shouldn't be a problem. |
||
| } | ||
|
|
||
| // func testGetPullRequests() { | ||
| // | ||
| // let params = [ | ||
| // "repo": "my/repo" // TODO: fill in accessible enterprise github repo | ||
| // ] | ||
| // | ||
| // self.tryEndpoint(.GET, endpoint: .PullRequests, params: params) { (body, error) -> () in | ||
| // | ||
| // XCTAssertNotNil(body, "Body must be non-nil") | ||
| // if let body = body as? NSArray { | ||
| // let prs: [GitHubPullRequest] = GitHubArray(body) | ||
| // XCTAssertGreaterThan(prs.count, 0, "We need > 0 items to test parsing") | ||
| // Log.verbose("Parsed PRs: \(prs)") | ||
| // } else { | ||
| // XCTFail("Body nil") | ||
| // } | ||
| // } | ||
| // } | ||
| // | ||
| // func testGetBranches() { | ||
| // | ||
| // let params = [ | ||
| // "repo": "my/repo" // TODO: fill in accessible enterprise github repo | ||
| // ] | ||
| // | ||
| // self.tryEndpoint(.GET, endpoint: .Branches, params: params) { (body, error) -> () in | ||
| // | ||
| // XCTAssertNotNil(body, "Body must be non-nil") | ||
| // if let body = body as? NSArray { | ||
| // let branches: [GitHubBranch] = GitHubArray(body) | ||
| // XCTAssertGreaterThan(branches.count, 0, "We need > 0 items to test parsing") | ||
| // Log.verbose("Parsed branches: \(branches)") | ||
| // } else { | ||
| // XCTFail("Body nil") | ||
| // } | ||
| // } | ||
| // } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm this will be tricky when someone tries to add a service not on any supported server. Could you instead try to synchronously ping the server and detect whether it really is a GitHub Enterprise server? We'll need this anyway to support more self-hosted servers like BitBucket Server - we'll need to ping the parsed host and detect which type it is. So using the
defaultbranch of the switch is here might cause issues with error reporting (we'll let users add even completely unsupported servers, which I'd like to avoid).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've got a check for this now. I don't know if it's robust enough for you, but it was the best I could come up with.