Fix for canceled integrations during Checkout #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ut phase (wouldn't yet have its SHA available in the blueprint) and Builda kept trying to integrate again.
|
Result of integration 1 |
|
Result of integration 3 |
czechboy0
pushed a commit
that referenced
this pull request
May 14, 2015
…ing_checkout Fix for canceled integrations during Checkout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for the case when an integration was canceled during the checkout phase (wouldn't yet have its SHA available in the blueprint) and Builda kept trying to integrate again. Because it didn't yet have an integration with the latest commit's SHA. Now if there's such an integration (no commit SHA in the blueprint and result 'canceled'), we assume it was on the latest commit, thus stopping builda from reintegrating again (until the user doesn't force an integration in the Xcode UI, because they must have already used it to cancel the previous integration).
Fixes #46.