Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update protobuf from 26.0 -> 28.1 and absl to latest lts #7401

Merged
merged 8 commits into from
Sep 17, 2024

Conversation

tempoz
Copy link
Contributor

@tempoz tempoz commented Sep 9, 2024

Need to confirm this builds on all of our production platforms; 27.3 did not and blocked release last week.

All warnings are removed; builds both with and without bazelmod.

Related issues: N/A

@tempoz tempoz changed the title Update protobuf from 26.0 -> 28.0 Update protobuf from 26.0 -> 28.1 Sep 11, 2024
@tempoz tempoz changed the title Update protobuf from 26.0 -> 28.1 Update protobuf from 26.0 -> 28.1 and absl to latest lts Sep 11, 2024
@tempoz tempoz marked this pull request as ready for review September 11, 2024 21:32
Copy link
Contributor

@sluongng sluongng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Not sure why CI is failing though.

WORKSPACE.bzlmod Outdated Show resolved Hide resolved
MODULE.bazel Show resolved Hide resolved
WORKSPACE Outdated Show resolved Hide resolved
@tempoz tempoz merged commit 73e1d91 into master Sep 17, 2024
15 checks passed
@tempoz tempoz deleted the update-protobuf-2 branch September 17, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants