deduper: Track job existence instead of running state #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrJosh9000
force-pushed
the
deduper-job-existence
branch
from
0c0362b
to
f47f822
Compare
DrJosh9000
force-pushed
the
deduper-job-existence
branch
from
f47f822
to
71b1c9b
Compare
CerealBoy
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Reduce the deduper to only tracking job creation and deletion.
Why
A finished job (complete or failed) still exists in the cluster for some time afterwards. So (for deduplication purposes) it should still be treated as in-flight all the way until it is deleted.
This fixes a gap in #438: suppose a job fails without starting a pod. The controller will try to recreate it and fail. With #438 the job will remain in the deduping map and won't be removed, meaning that even once the job is cleaned up through TTL, the controller won't try to create it again. With this PR, the deduping map no longer contains the job after deletion.