🎨 Improve the structure of some internal packages #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcncl
commented
Feb 13, 2025
Comment on lines
+22
to
+25
| v.AddRule("Organization", validation.Required) | ||
| v.AddRule("Organization", validation.Slug) | ||
| v.AddRule("Pipeline", validation.Required) | ||
| v.AddRule("Pipeline", validation.Slug) |
There was a problem hiding this comment.
This is an example of how we can add validation to commands
mcncl
commented
Feb 13, 2025
|
|
||
| // Add artifacts if present | ||
| if len(v.Artifacts) > 0 { | ||
| sections = append(sections, v.renderArtifacts()) |
There was a problem hiding this comment.
Our rendering functions are now split out in to their own files, so this can be cleaner and we can just add more if needed
mcncl
commented
Feb 13, 2025
Comment on lines
+3
to
+5
| type Rule interface { | ||
| Validate(value interface{}) error | ||
| } |
There was a problem hiding this comment.
A Rule just needs to have a function, Validate which takes in a value of any type and returns an error
mcncl
requested review from
lizrabuya,
PriyaSudip and
jykingston
as code owners
PriyaSudip
reviewed
Feb 13, 2025
PriyaSudip
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
scopesto ourvalidationpackagevalidationpackage out for clarity/easy addition of rulesbuildinternalsviewpackage to our/internal/build, which contains the individual focuses of thebuildpackage