[Columns] Fix check for child as lazy node Column #891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabro
approved these changes
Aug 28, 2024
|
@gabro I made a bento build with the fix locally, replaced the updated build onto a Next.js project's node_modules and run the app 😄 <Columns space={16}>
<Column>
<Body size="small">Server A</Body>
</Column>
<Column width="3/5">
<Body size="small">Server B</Body>
</Column>
<Column>
<Body size="small">Server C</Body>
</Column>
</Columns>(client is the same but on a file with Result: both server and client keep the width. |
|
Good enough! Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #835
Fix based on this comment. As the check now uses internals from a canary version of React any future updates to the payload format could break the check.