#1164: Popover does not work on React16 when attached to body (closes #1164) #1165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemobot
added
in review
giogonzo
approved these changes
Jan 3, 2018
src/Popover/Popover.tsx
Outdated
|
|
||
| // add pointer to popover node | ||
| this.popoverNode = this.containerNode.children[0]; | ||
| // render Popover and save popover size in "onMount" cb (visible popover will be rendered in componentDidUpdate) |
There was a problem hiding this comment.
did you read this facebook/react#10309 (comment) ?
Seems slightly simpler (but same thing at an higher level)
nemobot
added
waiting for merge
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1164
Test Plan
tests performed
example with
attachToBodyworks both on React16 and React15cross browser compatibility
tests not performed (domain coverage)