Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow maximum platform api version to be configurable #1024

Closed
tomkennedy513 opened this issue Sep 1, 2022 · 0 comments · Fixed by #1025
Closed

Allow maximum platform api version to be configurable #1024

tomkennedy513 opened this issue Sep 1, 2022 · 0 comments · Fixed by #1025
Assignees
Milestone

Comments

@tomkennedy513
Copy link
Collaborator

tomkennedy513 commented Sep 1, 2022

Make kpack controller configurable with a MAXIMUM_PLATFORM_API_VERSION configuration so that when a build pod is generated kpack will select the minimum between the configured value and the max supported version of the lifecycle

example

MAXIMUM_PLATFORM_API_VERSION= 0.8
lifecycle max platform api = 0.9
---> kpack uses 0.8

MAXIMUM_PLATFORM_API_VERSION= 0.8
lifecycle max platform api = 0.7
---> kpack uses 0.7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant