Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Utilize Platform API 0.9 when available #998

Closed
matthewmcnew opened this issue Jul 27, 2022 · 3 comments · Fixed by #1026
Closed

Utilize Platform API 0.9 when available #998

matthewmcnew opened this issue Jul 27, 2022 · 3 comments · Fixed by #1026
Assignees
@tomkennedy513 @yaelharel
Milestone
kpack 0.7.0

Comments

@matthewmcnew
Copy link
Collaborator

matthewmcnew commented Jul 27, 2022 •
edited
Loading

Background

When builds are executed with Platform API 0.9 or greater they will omit the legacy BOM from the output image. This will prevent the image from having potentially problematic large label sizes. This should resolve some issues with reported images built by kpack.

Additional Context

  • This should be documented as a possible breaking change.
  • This should be released alongside the bom support being removed from kp. Remove BOM support kpack-cli#261
@matthewmcnew matthewmcnew added this to the kpack 0.7.0 milestone Jul 27, 2022
@matthewmcnew
Copy link
Collaborator Author

For some consumers of kpack built images, the removal of the "legacy" bom will be a breaking change. To mitigate this the kpack should provide a mechanism to configure which platform api is used. It may make sense to do this at a cluster level.

@tylerphelan tylerphelan mentioned this issue Aug 17, 2022
Closed
@tylerphelan
Copy link
Contributor

tylerphelan commented Aug 17, 2022 •
edited
Loading

idea: Make kpack controller configurable with a MAXIMUM_PLATFORM_API_VERSION configuration

yaelharel pushed a commit to yaelharel/kpack that referenced this issue Aug 26, 2022
platformAPI can't be larger than MAXIMUM_PLATFORM_API_VERSION
50f032c 
Fixes buildpacks-community#998

Signed-off-by: Yael Harel <yharel@vmware.com>
@tomkennedy513
Copy link
Collaborator

created #1024 to handle configurable platform api version

@tomkennedy513 tomkennedy513 mentioned this issue Sep 1, 2022
Merged
@tomkennedy513 tomkennedy513 self-assigned this Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomkennedy513 tomkennedy513

@yaelharel yaelharel

Labels
None yet
Projects
None yet
Milestone
kpack 0.7.0
Development

Successfully merging a pull request may close this issue.

Add support for platform api 0.9 and bump lifecycle to 0.14.1 buildpacks-community/kpack
4 participants
@matthewmcnew @tylerphelan @tomkennedy513 @yaelharel