Use /tmp/termination-log for windows and linux #1052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tylerphelan
commented
Oct 27, 2022
tylerphelan
commented
- /dev/termination-log is a non-writable file in linux and windows on containerd
tylerphelan
requested review from
yaelharel,
tomkennedy513,
chenbh and
matthewmcnew
tomkennedy513
approved these changes
Oct 27, 2022
Codecov Report
@@ Coverage Diff @@
## main #1052 +/- ##
=======================================
Coverage 70.02% 70.02%
=======================================
Files 122 122
Lines 5908 5908
=======================================
Hits 4137 4137
Misses 1358 1358
Partials 413 413
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
- /dev/termination-log is a non-writable file in linux and windows on containerd
tylerphelan
force-pushed
the
termmsgpath-windows
branch
from
6c4a392 to
a3e7254
Compare
sambhav
approved these changes
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.