Handle nil build spec when reading creation time #1053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomkennedy513
requested review from
matthewmcnew,
tylerphelan,
chenbh and
yaelharel
tylerphelan
approved these changes
Oct 28, 2022
Ya I'll write one now |
tylerphelan
reviewed
Oct 28, 2022
| @@ -349,6 +349,24 @@ func testImageBuilds(t *testing.T, when spec.G, it spec.S) { | |||
| assert.Equal(t, image.Spec.Notary, build.Spec.Notary) | |||
| assert.Equal(t, image.Spec.Cosign, build.Spec.Cosign) | |||
| }) | |||
|
|
|||
| it("sets the creation time when present", func() { | |||
There was a problem hiding this comment.
oh snap assumed we at least had this one
|
If you don't mind a little scope creep, do you mind adding documentation for |
matthewmcnew
approved these changes
Oct 31, 2022
chenbh
approved these changes
Oct 31, 2022
tomkennedy513
force-pushed
the
nil-build-spec
branch
from
f639297 to
5564c36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.