Git: parse short scp-like syntax into proper SSH URLs #1067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenbh
force-pushed
the
convert-git-ssh-urls
branch
from
50c1b4a to
524058f
Compare
chenbh
changed the title
Codecov Report
@@ Coverage Diff @@
## main #1067 +/- ##
==========================================
+ Coverage 70.38% 70.41% +0.03%
==========================================
Files 122 123 +1
Lines 5912 5919 +7
==========================================
+ Hits 4161 4168 +7
Misses 1348 1348
Partials 403 403
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
currently we're lelying on an underlying library (libssh2) to be able to handle the shorter `[user@]host:path` syntax, but we should be good citizens and convert it ourselves. one key thing to note is that we don't convert any syntax that omits the user (i.e. `host:path`). while git allows this and will use the current user (i.e. cnb), this is a behaviour we don't want people to rely on. Signed-off-by: Bohan Chen <bohanc@vmware.com>
chenbh
force-pushed
the
convert-git-ssh-urls
branch
from
524058f to
d9c3587
Compare
tylerphelan
approved these changes
Nov 16, 2022
yaelharel
approved these changes
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1066
Parse all git URLs before passing to git2go. The parser will convert any short scp-like syntax to proper SSH style ones and leave all other URLs the same.